Use more contrast colors for recognized names of fields#101
Open
Mingun wants to merge 1 commit intolapo-luchini:trunkfrom
Open
Use more contrast colors for recognized names of fields#101Mingun wants to merge 1 commit intolapo-luchini:trunkfrom
Mingun wants to merge 1 commit intolapo-luchini:trunkfrom
Conversation
Owner
|
This is a very nice idea! |
Owner
|
I'm merging that in a branch, then I'll think about the color in a later commit. |
Owner
|
Commit imported on branch github-101. |
Author
|
Thank you. Of course, choose appropriate colors, I just gave an example |
Author
|
Does this actually be applied? I still see the old colors on https://lapo.it/asn1js/ |
lapo-luchini
force-pushed
the
trunk
branch
3 times, most recently
from
fe54b93 to
8d5f51d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With old colors, it is difficult to distinguish a recognized field name from a type name, and as a result, it is difficult to understand where names were recognized and where they were not.
Examples:
Dark theme:
Light theme: